Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ppc64 build option #156

Merged
merged 1 commit into from
Dec 17, 2019
Merged

Add ppc64 build option #156

merged 1 commit into from
Dec 17, 2019

Conversation

Pavel-P
Copy link
Contributor

@Pavel-P Pavel-P commented Dec 16, 2019

Tested with bazel 1.1.0, ubuntu 16.04, ppc64le
All tests pass except lockfree (but I don't see any obvious fixes here)

@nelhage
Copy link
Owner

nelhage commented Dec 17, 2019

Amazing, thanks.

I don't suppose you know of any services that offer free PPC64 CI for open-source projects, to ensure we don't break this going forward?

@nelhage nelhage merged commit 46d6337 into nelhage:master Dec 17, 2019
@nelhage nelhage mentioned this pull request Dec 17, 2019
@Pavel-P
Copy link
Contributor Author

Pavel-P commented Dec 17, 2019

Nope, sorry :( this was a bit of an ad hoc thing for me

@felker
Copy link
Contributor

felker commented Jan 29, 2020

Thanks for adding this @Pavel-P! I come from a thread on trying to build https://github.com/ray-project/ray on ppc64le: ray-project/ray#4309

@amitsadaphule and I independently made similar edits to BUILD.boost to get it to work.

@nelhage, as I noted in ray-project/ray#4309 (comment), Travis CI offers free PPC64 builds for open-source projects as of November.

@nelhage
Copy link
Owner

nelhage commented Jan 29, 2020

@felker That's awesome, thanks for the pointer. I've added it to my backlog to take a look, but I'd also happily accept a PR to add a travis.yml (and set us up with Travis) if you or @Pavel-P felt inspired to do that work :)

@felker
Copy link
Contributor

felker commented Jan 29, 2020

@nelhage done, see #161

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants